I have written like this..Any error in that?