What are peoples thoughts on keeping package-lock....
# dev-opsd
darrenhillconsulting
02/02/2021, 4:36 PMWhat are peoples thoughts on keeping package-lock.json in your repo?
s
stalbert
02/02/2021, 4:41 PMI think that should be checked in.
stalbert
02/02/2021, 4:42 PMnpm thinks so too https://docs.npmjs.com/cli/v6/configuring-npm/package-lock-json
d
darrenhillconsulting
02/02/2021, 4:42 PMya, i read that a lot. the merge conflicts it causes sometimes though
s
stalbert
02/02/2021, 4:42 PMif it's causing merge conflicts then it's helping you out.
stalbert
02/02/2021, 4:43 PMif you didn't commit it, you'd have different versions of things silently being used and silently ignored when you merged.
d
darrenhillconsulting
02/02/2021, 4:43 PMMaybe I'm naive, but doesn't the package.json keep that inline?
s
stalbert
02/02/2021, 4:45 PMI think the link above explains the purpose well enough?
stalbert
02/02/2021, 4:45 PMperhaps put another way, package.json is the top level, package-lock.json is the detail.
d
darrenhillconsulting
02/02/2021, 4:45 PMYa, I've read it all ... was getting some community feedback
s
stalbert
02/02/2021, 4:46 PMit's likely less critical in NS work depending on how you're using NPM I suppose.
j
Josh Godfrey
02/02/2021, 6:36 PMWe keep ours in our Repo, but I'm not sure if that's the best practice.. We are still in the early stages of setting up our workflow.
s
stalbert
02/02/2021, 6:37 PMit is definitely best practice imho
j
Josh Godfrey
02/02/2021, 7:01 PM@stalbert thanks for sharing the NPM docs. I'll definitely check it out.
m
michoel
02/02/2021, 10:12 PMIt's definitely best practice in general, but for NetSuite specifically node dependencies would almost always be dev dependencies. At worst version discrepancies would break the build but not actual scripts
s
stalbert
02/03/2021, 1:09 AMI use node modules in actual scripts
m
michoel
02/03/2021, 1:10 AMDo you have a build process that copies from node_modules to file cabinet directory?
s
stalbert
02/03/2021, 1:11 AMno, but I certainly could. since sometimes I have to edit the node source to be NS compatible.... but it's good to know exactly where the original source came from
stalbert
02/03/2021, 1:12 AMI hope that NS devs can use node modules more often over time - think of all the many thousands of libs it represents
m
michoel
02/03/2021, 1:13 AMIf you are copying manually then you don't really have a concern of version updates breaking things
michoel
02/03/2021, 1:13 AMI played around with webpack at some point to be able to do this https://github.com/michoelchaikin/netsuite-webpack
👏 1
michoel
02/03/2021, 1:13 AMI have heard that NetSuite is working on a supported way to import npm modules directly
💯 1
netsuite halo 1
s
stalbert
02/03/2021, 3:00 PMif they would just support native JS modules I'd be happy
4 Views