Is there a feature request for the plugin? i want ...
# sdfc
creece
10/13/2020, 3:52 PMIs there a feature request for the plugin? i want to upload files like my older plugin does where I don't have to start at the root of the file cabinet. I just dont have the time to maintain mine so looking to get it implemented within the current plugin. You can even take my code on github as the work is done for you.
s
stalbert
10/13/2020, 3:55 PMI'd echo this and also request that single file upload be made faster. Old tools I used to use could upload a script file in around 1-2 second. Somehow both the CLI and Webstorm are still much slower than that.
c
creece
10/13/2020, 4:01 PMIt could be logging in every time vs keeping you logged in. My plugin had the same issue and netsuite's own people submitted a pull request with the updates so they def know how
s
stalbert
10/13/2020, 4:02 PMI vaguely recall the plugin doing some sort of file cabinet search [to find folder id?] before doing the upload as being a big reason for the slowdown?
stalbert
10/13/2020, 4:03 PMI'd really like to see the system cache the folder ids used in a project. Posting a file directly to a folder when you already have the internal id results in that 1-2 second response time, methinks.
c
creece
10/13/2020, 4:03 PMSince they limit to the root of the file cabinet, there shouldn't be that much searching going on. Can't see their code so no idea for certain.
creece
10/13/2020, 4:03 PMThats what I did. I cache the ID and use it so it doesn't have to do a ton of work
s
stalbert
10/13/2020, 4:04 PMThat sounds like a much more performant approach! Go steal @creeceās code @Ali Syed (NS DevTools QA) š
š
2
c
creece
10/13/2020, 4:05 PMThe searching should also be recursive as its a directory structure so the code is probably not the easiest to follow but thats how you traverse the file directory system.
creece
10/13/2020, 4:06 PMI wish the actual plugin was open source. I'd just do this myself.
šÆ 1
a
Ali Syed (NS DevTools QA)
10/13/2020, 4:06 PM@creece Which plugin version are you using?
File upload performance was improved in the latest one.
c
creece
10/13/2020, 4:07 PMI don't use it at all (right now) because I need specific folder upload capability and not starting at the root FIle Cabinet folder.
creece
10/13/2020, 4:08 PMI need the ability to set my project root to anywhere I want and then it'll use that root as reference to upload. What is happening now is the root is ALWAYS set to File Cabinet. While honestly, this is probably the best approach, "legacy" clients don't always follow this structure.
creece
10/13/2020, 4:09 PMThe risk of moving the files to the FIle Cabinet root involves a lot of extra work as there could be some broken paths in scripts.
a
Ali Syed (NS DevTools QA)
10/13/2020, 4:11 PMCan you give an example?
For example with SDF.
ACP's files are uploaded under /SuiteScripts
Suiteapps - Suiteapp/com.xxxxx.xxx/
And there are other templates folders where user can upload.
Trying to understand your use case
c
creece
10/13/2020, 4:13 PMLets say I don't want to use suitescripts
creece
10/13/2020, 4:14 PMI have some random folder somewhere w/ code in it
creece
10/13/2020, 4:15 PMSDF file upload is not going to work because it goes back to File Cabinet / Suite Scripts.. yes, people SHOULD follow that, but legacy clients and some rebels don't. In that scenario (which is quite often), the SDF File upload will not be able to perform its task due to the directory structure.
s
stalbert
10/13/2020, 4:16 PMnot to hijack things, but a related feature I've love to see is the ability to map files from source folder locally to some target folder in NS FileCabinet. For example I may want to have something under
node_modulesnode_modules/blahblah/etc/c
creece
10/13/2020, 4:17 PMYou aren't hijacking that sounds like exactly what Im after
a
Ali Syed (NS DevTools QA)
10/13/2020, 4:20 PMYes, i understand. Well what i can do is convey this to the relevant people.
They can analyse the workflow and decide what to do.
File upload follows the same restriction as deploy.
As a suitecloud project expects some files under some specific directories.
If you try to create a new folder at the same level of /SuiteScripts, the deploy will fail as its against SDF deploy rules.
Thats why file upload behaves same.
Just out of curiosity, if file upload lets you create and upload files at same directoy level as /SuiteScripts, but deploy doesn't allow that. will that work for you?
šŗ 1
c
creece
10/13/2020, 4:27 PMRight. You (NS) are telling us (the devs) that certain things are against these "new" rules. That is fine for new projects/clients. Older clients didn't always follow this and files need to uploaded elsewhere. So its like you left older clients in the dust for this tool when this feature would solve that completely.
creece
10/13/2020, 4:28 PMSo my claim is there is no need restrict like you're doing. Security by obscurity is not security. If I want to upload or deploy into whatever folder I want I should be able to do that. Whether or not that follows the "best practices" would be on the client I'd think
creece
10/13/2020, 4:30 PMMy plugin did this and has like 15k+ downloads. I've not 1 time ever seen feedback that not restricting a folder was a problem. Thats actually why people use it to this day so I am just trying to get it built into the official one.
a
Ali Syed (NS DevTools QA)
10/14/2020, 2:50 PMI have conveyed these concerns, and will update you whenever there is news. Or maybe will setup a meeting with you to understand better the needs.
šŗ 1
š 1
s
stalbert
10/14/2020, 5:30 PMI think you can feature request for the CLI at least, via the open github repo?