Is there a way to add the the json-ld schema? or d...
# suitecommercek
kkennedydesign
03/17/2021, 1:59 PMIs there a way to add the the json-ld schema? or do we just have to add it in the templates?
s
Steve Goldberg
03/17/2021, 2:09 PMk
kkennedydesign
03/17/2021, 2:11 PMThanks Steve
s
Steve Goldberg
03/17/2021, 2:13 PMYou will need to scroll up and click "Show Inherited" first 😄
Steve Goldberg
03/17/2021, 2:13 PMAnd as that implies, it's inherited by every other visual component, so you can use PDP.modifyViewJsonLd() for example
k
kkennedydesign
03/17/2021, 2:16 PMYes - I found it. So within the function I can get use something like pdp.getItemInfo() to get the values I need to add I am assuming
s
Steve Goldberg
03/17/2021, 2:17 PMI haven't tried it but that sounds right to me
k
kkennedydesign
03/17/2021, 2:18 PMok - will report back ;>)
kkennedydesign
03/17/2021, 2:49 PMJust noticed that enabling this feature causes cms pages not to load so I think we need to turn it off.
s
Steve Goldberg
03/17/2021, 2:52 PMEh?
k
kkennedydesign
03/17/2021, 2:53 PMyep….blank cms pages
s
Steve Goldberg
03/17/2021, 2:59 PMI'm not seeing that. Could you share more details?
k
kkennedydesign
03/17/2021, 3:00 PMhere’s an example on a dev site https://tb.designedinthecloud.com/Shipping-Information
kkennedydesign
03/17/2021, 3:00 PMit is fine in Chrome, not so much in Firefox
s
Steve Goldberg
03/17/2021, 3:01 PMWell I'm not seeing either of them work for me
Steve Goldberg
03/17/2021, 3:02 PMDifferent errors in each
Steve Goldberg
03/17/2021, 3:02 PMAh no, same problem just different description of the error
k
kkennedydesign
03/17/2021, 3:03 PMha - im running local in chrome so thats why its working for me
s
Steve Goldberg
03/17/2021, 3:04 PMAh ok. So you're not using modifyViewJsonLd... you've just switched over to using JSON LD
Steve Goldberg
03/17/2021, 3:05 PMMy guess then is that you haven't configured the properties for this page correctly
k
kkennedydesign
03/17/2021, 3:06 PMyes - we just flipped it in configurations….is there something else that needs to be done?
kkennedydesign
03/17/2021, 3:09 PMsuiteanswers doesnt have much info
s
Steve Goldberg
03/17/2021, 3:10 PMNot as far as I know
Steve Goldberg
03/17/2021, 3:10 PMIs it all CMS pages or just this one
k
kkennedydesign
03/17/2021, 3:11 PMsupposedly all
kkennedydesign
03/17/2021, 3:12 PMwondering if there is some third party conflict
kkennedydesign
03/17/2021, 3:16 PMhmmm….still an error with GTM out
kkennedydesign
03/17/2021, 3:49 PMNot seeing the issue in other accounts.
s
Steve Goldberg
03/17/2021, 3:51 PMYeah I spent some time looking around. I'm not sure why it's happening. The deepest I went was looking at how the breadcrumbs are being created, considered that's where the error is being thrown
Steve Goldberg
03/17/2021, 3:52 PMSC.ENVIRONMENT.CMS.pages.pagesSteve Goldberg
03/17/2021, 3:52 PMThe trick would be to see what object is being passed to the breadcrumb generator just before it tries it but, with SCS that's a bit tricky as you can't edit the source files and add in some logs
Steve Goldberg
03/17/2021, 3:53 PMSomething like:
Copy code
var gvbcv = require('GlobalViews.Breadcrumb.View');
gvbcv.prototype.getJsonLd = _.wrap(gvbcv.prototype.getJsonLd, function (fn) {
var method = fn.apply(this, _.toArray(arguments).slice(1));
console.log(this.pages);
return method
})Steve Goldberg
03/17/2021, 3:54 PMMy other thought was that it doesn't like pipes (|) in names but that didn't seem to error on my site
k
kkennedydesign
03/17/2021, 4:14 PMOK - that is where I’ll start….we have a customization around that
s
Steve Goldberg
03/17/2021, 4:18 PMoh
Steve Goldberg
03/17/2021, 4:19 PMwell then yeah
Steve Goldberg
03/17/2021, 4:19 PMlol
k
kkennedydesign
03/17/2021, 4:19 PMbasically just using the name rather than the page title
kkennedydesign
03/17/2021, 4:20 PMand its broken for some other reason - it was next on my list so must be related
kkennedydesign
03/17/2021, 11:05 PMI de-activated the offending extension, reset the json-ld, and now the cms pages are fine. I have moved that extension up in priority to fix
2 Views