I created a custom theme using the 2018.1 base the...
# suitecommerce
k
I created a custom theme using the 2018.1 base theme, but am upgrading SCA to 2019.1. I want to upgrade the base theme to 2019.1 as well. I am looking for best practice tips for merging the new base theme with the existing custom theme.
s
I'd probably start by diffing the two base versions and see what's changed
k
this is a good point.....was discussed at one point to see if NS could provide the diff...otherwise every developer has to duplicate this effort...the folder names change because of the @sc-2019.xx or whatever and then the copyright year within the files are most likely different...2018 to 2019 ie......this requires extra steps in the diff process. Thoughts on this?
k
any thoughts @Caleb Evans?
p
@kkennedydesign i run this command: for file in *@*; do mv "$file" "${file%%@*}"; done (bash script) in the suitecommerce modules folder to remove the @ from folder names in order to do compares. Of course as you mention this doesn't avoid the copyright changes.
k
thanks - I do the simple Mac method - select all the folders, right click and replace the @ that way, but still, yeah, those copyrights make everything look changed
👍 1
s
Given that it's boilerplate, you could probably use a search+replace function in your IDE to remove them (temporarily, of course) for diffing purposes
k
true, but still a lot of duplicated effort!
s
message has been deleted
(I'll add it to my list)
p
you have a list? 😮
😂 1
🧐 1
🤯 1