We have pushed updates to the Product Reviews and Product Li NetSuite Professionals #suitecommerce

We have pushed updates to the Product Reviews and ...

Steve Goldberg

01/21/2025, 12:07 PM

We have pushed updates to the Product Reviews and Product List bundles. A patch for SCA sites is also required if you intend to use them: https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/article_4160229131.html#subsect_0108120330

👍🏻 1

Gordon Truslove

02/04/2025, 3:36 PM

I’ve got loads of these product list patches to install. First couple are the same. I’ve updated the code and deployed. I’ve updated the custom role on the service files. Everything seems to work in shopping but in my account all the lists are empty. Any idea what I missed?

Steve Goldberg

02/04/2025, 3:48 PM

That doesn't sound right.

🤷‍♂️ 1

Steve Goldberg

02/04/2025, 3:51 PM

I can't find any open issues around that. We did recently fix an error in 24.2.10 with product lists where newly created lists returned an error and an empty set of lists

Steve Goldberg

02/04/2025, 3:51 PM

Raise a case if you're sure it's a bug

Gordon Truslove

02/04/2025, 3:52 PM

Just realised it’s the same in shopping. It finds the lists but they’re all empty.

Gordon Truslove

02/04/2025, 3:52 PM

No error.

Steve Goldberg

02/04/2025, 3:53 PM

No error? Hmm

Steve Goldberg

02/04/2025, 3:53 PM

And the service response is an empty array?

Gordon Truslove

02/04/2025, 3:54 PM

Copy code

,"items":[]}

Steve Goldberg

02/04/2025, 3:54 PM

wwhhhuttt

Gordon Truslove

02/04/2025, 3:55 PM

oh ok, here’s a full response. Should have a load of items in the list:

Gordon Truslove

02/04/2025, 3:55 PM

Copy code

{
  "internalid": "933",
  "templateId": "",
  "name": "Bollé brands",
  "description": "",
  "owner": {
    "id": "4734",
    "name": "1000103 Fr Test"
  },
  "scopeId": "2",
  "scopeName": "private",
  "typeId": "1",
  "typeName": "default",
  "created": "24/11/2022 4:09 PM",
  "lastmodified": "24/11/2022 4:09 PM",
  "lastmodifieddate": "24/11/2022",
  "items": []
}

Steve Goldberg

02/04/2025, 3:57 PM

Yeah, I got nothing 🤷🏻

Gordon Truslove

02/04/2025, 3:57 PM

ok, I’ll see if I can debug is somehow.

Gordon Truslove

02/04/2025, 4:39 PM

Is the ns.package.json wrong in the patch somehow?

Steve Goldberg

02/04/2025, 4:42 PM

If you mean the weird curly brace then yes

Steve Goldberg

02/04/2025, 4:43 PM

I've already flagged it with the tech writer

Steve Goldberg

02/04/2025, 4:43 PM

Did fixing that fix your problem?

Gordon Truslove

02/04/2025, 4:44 PM

Also it mentions Configuration.js is that wrong too. What should it be. I tried to fix it and I get the feeling it’s not overrwriting properly.

Steve Goldberg

02/04/2025, 4:52 PM

... yes? Why does it say Configuration.js?

Gordon Truslove

02/04/2025, 4:53 PM

{ “gulp”: { “javascript”: [ “JavaScript/*.js” ] }, “overrides”: { “suitecommerce/{ProductList@X.Y.Z/SuiteScript/Configuration.js” : “SuiteScript/ProductList.Item.Model.js”, “suitecommerce/{ProductList@X.Y.Z/SuiteScript/Configuration.js” : “SuiteScript/ProductList.Item.Search.js”, “suitecommerce/{ProductList@X.Y.Z/SuiteScript/Configuration.js” : “SuiteScript/ProductList.Model.js”, “suitecommerce/{ProductList@X.Y.Z/SuiteScript/Configuration.js” : “SuiteScript/ProductList.ServiceController.js” } }

Steve Goldberg

02/04/2025, 4:54 PM

Why is it also specifying that it should include JavaScript and not SuiteScript

Gordon Truslove

02/04/2025, 4:54 PM

I’ve no idea. This seems very wrong to me, but I can’t seem figure out the magic correct answer.

Steve Goldberg

02/04/2025, 4:55 PM

Well it should include SuiteScript and not JavaScript

Steve Goldberg

02/04/2025, 4:55 PM

And as the docs say, we are overriding ProductReviews.Model.js not Configuration.js

Gordon Truslove

02/04/2025, 5:02 PM

I think this is what it should be. Still no items for me. I’ll keep trying.

Gordon Truslove

02/04/2025, 5:02 PM

{ “gulp”: { “javascript”: [ “JavaScript/*.js” ], “ssp-libraries”: [ “SuiteScript/*.js” ] }, “overrides”: { “Commons/ProductList/SuiteScript/ProductList.Item.Model.js”: “SuiteScript/ProductList.Item.Model.js”, “Commons/ProductList/SuiteScript/ProductList.Item.Search.js”: “SuiteScript/ProductList.Item.Search.js”, “Commons/ProductList/SuiteScript/ProductList.Model.js”: “SuiteScript/ProductList.Model.js”, “Commons/ProductList/SuiteScript/ProductList.ServiceController.js”: “SuiteScript/ProductList.ServiceController.js” } }

Steve Goldberg

02/04/2025, 5:05 PM

Which version are you patching?

Gordon Truslove

02/04/2025, 5:06 PM

Most of them are between 2019 and 2022. I’ve got 9 to sort 😩

Steve Goldberg

02/04/2025, 5:09 PM

Another problem with the docs is that they are written for old versions using the wrong paths

Steve Goldberg

02/04/2025, 5:09 PM

When you want to reference modules outside of the Advanced directory you have to do .. first

Steve Goldberg

02/04/2025, 5:09 PM

So ../Commons

Gordon Truslove

02/04/2025, 5:10 PM

I put my extensions folder outside of those folders.

Steve Goldberg

02/04/2025, 5:11 PM

Right, but did you do that when you updated the distro file?

Steve Goldberg

02/04/2025, 5:11 PM

Like am I being dense but surely this is wrong too?

Copy code

"modules": { "extensions/ProductReviews": "1.0.0", . . .

Steve Goldberg

02/04/2025, 5:12 PM

Shouldn't it be ../extensions/ProductReviews ?

Gordon Truslove

02/04/2025, 5:12 PM

The json I put in a couple of messages ago is definitely overriding now, but still no items. I’m trying to debug the saved search it’s using.

Gordon Truslove

02/05/2025, 4:53 PM

(Many hours later) This is what I’ve managed to work out. In the file ProductList.Item.Search.js > searchHelper it looks up the list of items using a suitescript saved search. The item type is null here where it should be something. const itemType = productListItemSearchRecord.getValue( ‘type’, ‘custrecord_ns_pl_pli_item’ );

Gordon Truslove

02/05/2025, 4:54 PM

I can fix this by defaulting this value to “inventoryitem” if it’s null. or by changing the role to something beefy like “CEO”.

Gordon Truslove

02/05/2025, 4:58 PM

Seems like an issue with the new role to me.

Steve Goldberg

02/06/2025, 11:37 AM

OK, I have seen a couple of colleagues mention that this might be happening to some other customers too

👍 1

Steve Goldberg

02/06/2025, 11:37 AM

Could you try using the original role but setting the Lists > Items > View permission?

Gordon Truslove

02/06/2025, 11:44 AM

That works! That’s annoying, one of the first things I did was try setting the items permission to Full and that didn’t work.

👍🏻 1

Steve Goldberg

02/06/2025, 1:51 PM

The team recognise this is as a problem. It currently only affects 25.1 instances, and an updated bundle is going to be pushed out that essentially implements what I just described

Gordon Truslove

02/06/2025, 1:52 PM

ok cool. At least it’s solved.

Steve Goldberg

02/06/2025, 1:52 PM

The team are also going to correct the incorrect code snippets in the docs too. Thanks for bringing both of these to my attention

👍 1

12 Views

Open in Slack

Previous Next