hi im trying to have a script run on all item types kit , inventory , lot inventory etc this is my current code

/**
 * @NApiVersion 2.x
 * @NScriptType UserEventScript
 * @NModuleScope SameAccount
 */
define(['N/record'],
    /**
     * @param {record} record
     */
    function (record) {
        function afterSubmit(scriptContext) {
            //Step 1
            rec = scriptContext.oldRecord;

            //Step 2
            var extId = rec.getValue({ fieldId: 'externalid' });
            var amazonsku = rec.getValue({ fieldId: 'custitem3'  });

            //Step 3
            if (amazonsku != extId) {
                //Step 4
                record.submitFields({
                    
                    id: rec.id,
                    values: {
                        'externalid': amazonsku
                    }
                });
            }
            //Step 5
            var newext = rec.getValue({ fieldId: 'externalid' });
            log.debug('rec id', rec.id)
        }
        return {
            afterSubmit: afterSubmit
        };
    });

Dont use record.submitFields, get this information in beforeSubmit and just set it on the record.

i got this basic code from suite answers to use after submit

You dont really have a choice in the matter

meaning

You cant edit the external id in beforeSubmit

Really? I had never tried it, but didn’t think it would be prohibited.

in record.submitFields do i have to set the record type

yes, type is required to use that function

i have multible types inventory , lot inventory assembly

try using

rec.type

?

yes but i need to set that dynamically

although im not sure why you would use the old record vs the new record, use Record.type

good points im going to rewrite this script !

You would be getting the type property from the current record (old or new)

scottvonduhn is right - rec.type in your code =

scriptContext.oldRecord.type

this will give you the record type that battk is talking about - which will make your code dynamic then you will need to do

record.submitFields({
                    type:rec.type,
                    id: rec.id,
                    values: {
                        'externalid': amazonsku
                    }
                });

so shoul iuse old record or new record ?

almost always it's new record, in this case it doesn't matter*, but do note that when the fields are not changed sometimes it might not be available in context.newRecord there are a few workarounds, but that's a different topic *if amazonsku won't be updated

thanks guys script works now

Depends what you wrote for your version

Well create might not have an

oldRecord

so if you are referencing that, could definitely be a problem

but this is a after submit script so shouldn't it have a record ?

nope