Never mind, not even paying attention to my own code....... 🤦 OK, I'm having an interesting issue with my code and some calculations. I know that there can be some issues with certain floating point numbers, but has anyone dealt with a scenario where the exact same equation, run twice produces two different results? Example below:

const val1 = 172.5 + Math.ceil((445200 - 100000) / 100) * 100 / 1000 * 1.5
const val2 = 172.5 + Math.ceil((445000 - 100000) / 100) * 100 / 1000 * 1.5

console.log(val1)
console.log(val2)

Results:
PS C:\Users\mcarter\Documents\VsCode\netsuite investigate> node .\test2.js
690.3
690

They're not the same calc. You have 445200 in the first, and 445000 in the second.

😂 Well, that will do it........

this is also where I suggest you consider BigNumber (which is already there if you're using NFT)

roundByExponent.js

If you insist on an arrow function there, you can simplify it even further by dropping the curly braces and the

return

statement as it's implied.

I'm very insistent with coding standards too, in NetSuite the odds are that you will have a mix of 2.0 and 2.1 at least, so I don't like the idea of getting rid of `{}`(never like it without this) or

return

for code readability and maintenance.

umm, in that case you shouldn't be using arrow functions at all. You should be using

function

statements.

I'm failing to see why I should do that. In my mind and others like: • https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/ • https://contribute.jquery.org/style-guide/js/ • https://google.github.io/styleguide/jsguide.html And finally: • https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions Using arrow functions

=>

with

{}

and

return

is perfectly valid syntax, and you sort of keep a consistent coding standard with your old code base without having to use the old

function

initialization. I use this also as a way to identify and/or isolate 2.1 code from 2.0 code without having to scroll up to check. I take advantage of everything related to ES6 in 2.1, with the only exception of keeping

{}

and

return

again for code readability purposes.

You mentioned wanting consistency between 2.0 and 2.1. It's my understanding that arrow functions aren't supported in 2.0 so your example code using them would utterly fail in 2.0. Considering clarity, I can't see how

const roundByExponent = (pValue, pDecimals) => {

is at all easier to read/understand than

function roundByExponent (pValue, pDecimals) {

The

{}

and

return

are not the only differences between

function

and

=>

, yes I do want to keep consistency

as much as I can

between 2.0 and 2.1 without sacrificing what I get with

=>

as restrictions of

this

, and other things. Nice chat!...

agreed, treatment of

this

is important, but I rarely see SuteScript code in the wild actually referring to

this

or making assumptions about it. I've asked on this forum a couple times and it seems

this

is mostly avoided by SuiteScript devs (probably for the best, most of the time)