Questions about User Event scripts: I am working ...
# suitescripts
scottvonduhn
09/27/2023, 3:57 PMQuestions about User Event scripts: I am working with a customer UE from another account that is being merged into ours. It’s written in SS 1.0, and only runs when type equals ‘edit’ or ‘xedit’
When performing an edit through the UI, there was a call made to get the
'entityid'nlapiGetNewRecord().getFieldValue('entityid')netsuite 3
c
Clay Roper
09/27/2023, 4:36 PMAre there any differences in terms of account settings, configurations, or form/field requirements between the two accounts?
s
scottvonduhn
09/27/2023, 4:42 PMThere are most definitely differences in our account, we are two companies that have a 9 year history with NetSuite (both of us went live in 2014), so many years worth of differences could be present. Having said that, all account features they had enabled that we did not have now been enabled, and all of their customizations merged into our (workflows, scripts, forms, data, etc.)
I don’t know where to look, really. entityid is a standard field on customer, and I don’t know how the value could be nullified, or why it only happens half the time. The times when it is returning null do seem to be all triggered by UI edits, though. Scripted edits so far do not show this issue.
I figured that might suggest a client script, but could a CS modify what a user event sees in the NewRecord on a beforeSubmit?
c
Clay Roper
09/27/2023, 4:43 PMentityids
scottvonduhn
09/27/2023, 4:47 PMyes, it is the customer name field, it never goes blank that i can see, and i have encountered the issues when editing a customer myself (only changing an unrelated custom date field)
scottvonduhn
09/27/2023, 4:47 PMit has the same value before, during, and after submit
scottvonduhn
09/27/2023, 4:50 PMone big difference in our accounts: we have customer auto-numbering enabled, so entityid is always some unique number, then a space, followed by companyname. the other account did not use that feature, and just required companyname to be unique for every customer.
we have a use case for having multiple “copies” of a customer with the same companyname, but with different id prefixes to distinguish them
scottvonduhn
09/27/2023, 4:55 PMi have wondered if that causes the issue, however i can’t turn that setting off to test my theory
r
reptar
09/27/2023, 6:22 PMthat sounds like madness. good luck
b
battk
09/27/2023, 6:39 PMfields that dont actually take input are the ones most at risk of not actually being submitted
battk
09/27/2023, 6:42 PMin the ui, the save process is is triggered by a form post, and fields without inputs may not actually have an input element on the form to be submitted
battk
09/27/2023, 6:42 PMif you were to edit and save the record via script, you probably wont have the same problem
s
scottvonduhn
09/27/2023, 6:43 PMi wonder how it ever worked in old account, unless the customer auto-numbering setting changes the form (removes that field as an input)?
b
battk
09/27/2023, 6:44 PMwas there an actual input element that could be set in the other account?
s
scottvonduhn
09/27/2023, 6:46 PMthe same field, entityid. We have it labelled as Customer ID on the customer form in both accounts
scottvonduhn
09/27/2023, 6:48 PMthe only difference being that in the other account, entityid = companyname, but in our account, entityid = entitynumber + ' ' + companyname
scottvonduhn
09/27/2023, 6:51 PMLooking more closely, though, there is an Auto checkbox in the old account. if unchecked, that field is editable
scottvonduhn
09/27/2023, 6:51 PMit’s not at all editable in our account
b
battk
09/27/2023, 6:52 PMthe question i asked will make very little sense if you dont know what an html input is
s
scottvonduhn
09/27/2023, 6:52 PMi am aware
scottvonduhn
09/27/2023, 6:55 PMin our account, the field is just a span with class=“input”, but in the old account it’s an actual input tag
scottvonduhn
09/27/2023, 6:57 PMso, obviously the setting does make a difference, and directly impacts the ability to use entityid, but only on NewRecord, from the UI, and only if Auto-Generated Numbering is enabled
scottvonduhn
09/27/2023, 6:59 PMI never actually suspected that the html form itself controlled what was available in the NewRecord, I just assumed that all fields would be available if visible
scottvonduhn
09/27/2023, 7:00 PMstrangely, though, custom fields on customer that are set to Inline Text still do have an input tag in the html form, but not the Customer ID / entityid
b
battk
09/27/2023, 7:03 PMmost of the time there is a hidden input element on the page somewhere
battk
09/27/2023, 7:04 PMsometimes there isnt
s
scottvonduhn
09/27/2023, 10:00 PMWhat’s really interesting here is that the behavior varies by account according to a setting, (in terms of having the hidden input or not) which means that someone could develop code that works in their account, but have it break upon deployment to another account like ours, with this setting enabled.
For a while I was at a loss to explain to the admin of the other company why their code worked for years without fail, then suddenly stopped working in ours. At least now I know why, but seems like an unintentional oversight. NetSuite shouldn’t allow scripting to use a field that might be made unavailable in this way, since it returns null even when there is a value present. I’d rather that it gave an error since at least that would warn us against code like this, rather than silently returning a null. The fact that it only did so half the time made it even harder to figure out what was going on, but now I do see that it was consistent, it’s only UI edits that have this issue
e
ec
09/27/2023, 11:41 PMDid you check the Setup > Auto Generated Numbers in each account? Seems like that's the difference here
s
scottvonduhn
09/28/2023, 12:07 AMYes, that definitely is the difference, but we can’t (or really, don’t want to) turn it off for Customers. Modifying the code was the only viable option for us. The difference in behavior just surprised me.