ah so just delete the like number 5

Hi Jamie

Hi

I have a question, if you can help

I'll try, ask away

What do you see wrong, or what would you change, or consider changing, in the following code function? CLIENT SIDE SCRIPT RUNNING ON SALES ORDERS TRIGGER: FIELD CHANGE function fieldChange_setSalesRepSector(sublist, name){ if (sublist == 'item' && name == 'item') { var filters = []; filters.push(new nlobjSearchFilter('custentity_item', null, 'is', nlapiGetCurrentLineItemText('item', 'item'))); columns = []; columns.push(new nlobjSearchColumn('internalid')) var results = nlapiSearchRecord('employee', null, filters, columns); nlapiSetCurrentLineItemValue('item', 'custcol_rep_responsible', results[0].getValue('internalid'));

Yeah I was going to mention using getCurrentLineItemValue instead of Text. Also you might want to check if results has anything before using a value from it. For example

var results = nlapiSearchRecord('employee', null, filters, columns);

if(results.length > 0){
    nlapiSetCurrentLineItemValue('item', 'custcol_rep_responsible', results[0].getValue('internalid'));
}

is there any issue in these lines function fieldChange_setSalesRepSector(sublist, name){ if (sublist == 'item' && name == 'item') { var filters = [];

you could have the linenum variable in the function like

function fieldChange_setSalesRepSector(sublist, name, linenum)

if (sublist == 'item' && name == 'item') What this is checking in this line ?

It is checking that the sublist that has been edited was the item sublist and checking that the field on that sublist that was changed was the item field.

ok. Thank you very much , you have been helpful

You are welcome.

ok . Thanks a lot

This would however be possible to achieve with added sourcing on the field so that the value was pulled in when the item was added.

yeah, thats true. Even the value can be loaded in hidden field while the load performed , and then it can be used here without performing search