Anyone know why the 0.00 is showing as .00 ?
# suitescriptc
Craig
07/14/2023, 5:02 PMAnyone know why the 0.00 is showing as .00 ?
a
Anthony OConnor
07/14/2023, 5:16 PMnope, but ugly fix off the top of my head... just force add leading string zero to everything, and then parseFloat 🙂 on the resulting string.
c
Craig
07/14/2023, 5:16 PMDo you want to see an even uglier fix?
a
Anthony OConnor
07/14/2023, 5:16 PMYES
Anthony OConnor
07/14/2023, 5:17 PMI'm so here for that!
c
Craig
07/14/2023, 5:17 PMOld code:
if (!amount || amount === 0) {
continue;
}
New code
if (!amount || amount == 0) {
continue;
}
facepalm 1
Craig
07/14/2023, 5:17 PMspot the difference
a
Anthony OConnor
07/14/2023, 5:17 PMdoes ".00" == 0?
Anthony OConnor
07/14/2023, 5:18 PMlol js type things
Anthony OConnor
07/14/2023, 5:18 PMat least add a comment 😄 that's an awful bugfix
c
Craig
07/14/2023, 5:18 PM=== is veyr strict
Craig
07/14/2023, 5:18 PM== is a bit wider 😄
a
Anthony OConnor
07/14/2023, 5:19 PMi know that, but i didn't think it would be wide enough to assume a string starting with a non-numeric value could be parsed as a number
Anthony OConnor
07/14/2023, 5:21 PMmy IDE complains about == and != so if I need to effectively do that kind of comparission, I do it explicitly in my code by doing a conversion
c
Craig
07/14/2023, 5:21 PMlol
Craig
07/14/2023, 5:22 PMThe real issue is that 0.00 is coming back as .00 from the saved search.
a
Anthony OConnor
07/14/2023, 5:24 PMcan you at least not use
Copy code
if( !amount || parseFloat(amount) === 0 ) continue;Anthony OConnor
07/14/2023, 5:24 PMshould be fine that's effectively what == is doing here anyway
c
Craig
07/14/2023, 5:24 PMI assume parseFloat(".00") returns 0.00 ?
a
Anthony OConnor
07/14/2023, 5:24 PMi didn't realize pasrseFloat(".00") === 0
c
Craig
07/14/2023, 5:25 PMthat's better than == 🙂
a
Anthony OConnor
07/14/2023, 5:25 PMc
Craig
07/14/2023, 5:25 PMThat's fine, this whole script hinges on
if (amount > 0) {
a
Anthony OConnor
07/14/2023, 5:25 PMit would only return 0.00 if you toFixed(2)
c
Craig
07/14/2023, 5:25 PMwhich clearly fails int he .00 scenario
Craig
07/14/2023, 5:26 PMbut 0 is fine
Craig
07/14/2023, 5:26 PMI need to test that with other values too
👍 1
Craig
07/14/2023, 5:26 PMas everything will hit that parseFloat
a
Anthony OConnor
07/14/2023, 5:27 PMi assume they're all numbers though right? or null?
Anthony OConnor
07/14/2023, 5:27 PMparseFloat should be fine?
Anthony OConnor
07/14/2023, 5:27 PMbut yeah test it 😄
b
battk
07/14/2023, 5:32 PMyou need to actually test strings
battk
07/14/2023, 5:32 PMgetValue returns strings, its not returning 0, its returning '.00'
c
Craig
07/14/2023, 5:33 PMwhy is it returning .00?
Craig
07/14/2023, 5:34 PMwhen the value in the UI is 0.00 on the search?
b
battk
07/14/2023, 5:38 PMsame reason it ignores the ui formatting preferences
battk
07/14/2023, 5:39 PMwhatever is converting the number 0 to the string .00 is not the same code that is being used in the ui
c
Craig
07/14/2023, 5:39 PM.00 feels like something that's never useful.
Craig
07/14/2023, 5:40 PMI don't know why that's considered desirable as a return value for 0
Craig
07/14/2023, 5:40 PMor 0.00
a
Anthony OConnor
07/14/2023, 5:40 PMits a currency field?
c
Craig
07/14/2023, 5:41 PMI assume it's a currency field, it's the cogsamount
a
Anthony OConnor
07/14/2023, 5:41 PMprobably something dumb NS is doing... removes leading zeros first... THEN converts toString().toFixed(2) ?
Anthony OConnor
07/14/2023, 5:42 PMworks fine for every value other than 0 😂 ¯\_(ツ)_/¯
c
Craig
07/14/2023, 5:43 PM1.00 all good
0.00 enjoy your type errors
Craig
07/14/2023, 5:43 PMQuote from Evan Goldberg... probably
😂 1
a
Anthony OConnor
07/14/2023, 5:44 PMno type errors are for closers, sell more, don't have 0s
c
Craig
07/14/2023, 5:58 PMparseFloat seems ok, can't get it to fail.
👍 1
b
battk
07/14/2023, 5:59 PMyou have to keep in mind that the backend is java, so the answer is probably something like their DecimalFormat uses "#.00" as the pattern, with the # denoting an optional digit
this 1
r
raghav
07/14/2023, 6:38 PMNot sure it will be a better solution, but below is another solution you could have done
Using a formul field such that if the value is 0 return 0 otherwise return the value.
And this is optional in your code you could replace if the value is ===0 with 0.00 if required.
c
Craig
07/14/2023, 10:00 PMI went with the parseFloat() solution
👍 1
Craig
07/14/2023, 10:00 PMI couldn't come up with a failing test case.
4 Views