well there's one thing you'll pretty much know for sure it's me typing under this user name if you see typos particularly "teh"

@jmacdonald Would you mind to share the code to take a look, that look like a weird error...

When you push filters to a search, I'm assuming they have an 'and' relationship.. What if you want the filters to be or'ed? I'm looping through them so I can't write it explicitly.

@reptar To be ordered you need to sort your columns...

what? no i want this filter 'or' this filter 'or' this filter, sequentially. if i use Search.filters.push(filter) sequentially, it gives me filter1 and filter2 and filter3. i want filter1 or filter2 or filter3.

i'm specifying internal ids for time records. i want each time record to be returned by the search.

so they have to be or'd not and'ed.

@reptar This is an example of how I do it dynamically...

filters[i].push('OR')

is what i was looking for. thanks.

@alien4u

TypeError: Cannot find function _clone in object OR.

@reptar Something is wrong with your code...

@reptar @alien4u If you don't like mutation and enjoy purely functional programming you can use this for dynamic filters. In this example it is passing an array of accountIds and creating the filters for it. It is good for the searches where

anyof

doesn't work.

function filterQueryBuilder(accountIds) {
            return accountIds.map(function (accountId, i) {
                return [["entityid", "is", accountId]].concat(i !== accountIds.length - 1 ? ["OR"] : [])
            }).reduce(function (pre, cur) {
                return pre = pre.concat(cur)
            })
        }

functional programming is the absolute worst ;(

@Azi Thanks, is another way to skin a cat but the way I see this you are using: `map`+`concat`+`reduce`+`concat` again...the above code only use

map

and

push

...

it sure seems like the error is complaining about

time_search.filters.push('OR')

@reptar

var nPos = filters.push([])-1;

then

filters[nPos].push('OR');

You need to understand condition AND [ [condition] OR [condition] ]

i don't follow that line.

yur backing up by one. why?

Two things. 1) I recommend using filter expressions instead of filter objects. 2) It's a lot cleaner to get the list of time internal ids into an array, then transform them into search filters from the list, rather than trying to combine getting and transforming in one loop.

@reptar Because is the way a filter structure works...

AND and ORs are not at the same LEVEL...

i don't have any ands...

[ [condition] 'OR' [condition] ]

i'm gonna take a break. i have no idea what this line does:

var nPos = filters.push([])-1

@reptar Slow down take a break: what that does is to push to the filters array but that return the new array size and you want the previous position(where you inserted that empty

[]

) where you need to push next...

This is why you do push - 1 to get the previous position/the position where you just inserted and not the new array size...

My Search.filters looks like this:

[["internalid","IS","1898722"],"OR",["internalid","IS","1898746"],"OR",["internalid","IS","1898808"],"OR",["internalid","IS","1898832"],"OR",["internalid","IS","1898835"],"OR",["internalid","IS","1899859"],"OR",["internalid","IS","1899962"],"OR",["internalid","IS","1899964"],"OR",["internalid","IS","1908540"],"OR",["internalid","IS","1908546"],"OR",["internalid","IS","1908816"],"OR",["internalid","IS","1908899"],"OR",["internalid","IS","1899885"]]

(shortened for readability) but I'm still getting

TypeError: Cannot find function _clone in object internalid,IS,1898722.

when I run the search.

I have no CLUE what

_clone

is...